Skip to content

Translating forms.md#22

Closed
SahibArora wants to merge 11 commits into
reactjs:masterfrom
SahibArora:forms.md_to_hindi
Closed

Translating forms.md#22
SahibArora wants to merge 11 commits into
reactjs:masterfrom
SahibArora:forms.md_to_hindi

Conversation

@SahibArora

Copy link
Copy Markdown

Hi there,
Sorry I started working on it, before your reply, just a little bit excited towards my first open source contribution. Hope you don't mind.
I am just opening a PR request for forms which I will be updating with time. When I will be done, I will let you know.

Thank you,

@netlify

netlify Bot commented Mar 6, 2019

Copy link
Copy Markdown

Deploy preview for hi-reactjs ready!

Built with commit f0cc6df

https://deploy-preview-22--hi-reactjs.netlify.com

@arshadkazmi42 arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
I have left a few comments, let's fix all those feedback reviews first before continuing with further translations of page

Please read #23 before working on the review fixes

Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
@SahibArora

SahibArora commented Mar 7, 2019

Copy link
Copy Markdown
Author

Hi there,

Thanks for the suggestions.
I did the changes, you asked me.
Please give it a look and then I will continue further.

Thanks,

Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated

@arshadkazmi42 arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress.
Added some more comments and you have missed few of the previous suggestions

@SahibArora

Copy link
Copy Markdown
Author

I did the changes, thanks for your suggestions again.
I will carry on with the translating.
Thanks!

@arshadkazmi42

Copy link
Copy Markdown
Member

@SahibArora There is one line left for translation line 30, once you can do the translation of that line, I can review and approve it for second round of review.

@arshadkazmi42

Copy link
Copy Markdown
Member

@SahibArora Any updates on this? Let us know if you need any help from our end

@arshadkazmi42

Copy link
Copy Markdown
Member

@SahibArora Any updates on this? Let us know if you need any help from our end

@arshadkazmi42

Copy link
Copy Markdown
Member

@SahibArora Any updates?

@saranshkataria

Copy link
Copy Markdown
Contributor

@SahibArora please let us know if you will be working on this?

@SahibArora

Copy link
Copy Markdown
Author

Hi @arshadkazmi42,
I apologize for the delay and not been able to follow-up to your past messages.
I will go through it right away and submit the file as soon as possible.
Sorry again for the inconvenience caused because of me.

@saranshkataria

Copy link
Copy Markdown
Contributor

@SahibArora no worries. Just wanted to ensure that you will complete it. Let us know if you need any help

@saranshkataria

Copy link
Copy Markdown
Contributor

@SahibArora any updates?

@saranshkataria

Copy link
Copy Markdown
Contributor

Closing this PR due to inactivity. Feel free to reopen if you are going to work on it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants